Reviewers: Rico,
Message:
Hi Rico,
I just prepared to switch from sample shell to d8. I changed the files for
tools/test.py to use d8 by default. However, Mads told me that there are a
few
more things to be changed, of which you know best.
There is a new command line option for d8: adding --test makes things go
slightly faster. This can add up especially for the slow arm simulator. It's
specially designed to be used with unit testing.
Thanks,
Yang
http://codereview.chromium.org/7282008/diff/1/tools/test.py
File tools/test.py (right):
http://codereview.chromium.org/7282008/diff/1/tools/test.py#newcode1275
tools/test.py:1275: if options.shell == "d8":
adding --test as command line option makes things go slightly faster,
but only suitable when using d8 for unit tests like here.
Description:
switch from sample shell to d8 for unit test
Please review this at http://codereview.chromium.org/7282008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/benchmarks/testcfg.py
M test/es5conform/testcfg.py
M test/message/testcfg.py
M test/mjsunit/testcfg.py
M test/mozilla/testcfg.py
M test/sputnik/testcfg.py
M test/test262/testcfg.py
M tools/test.py
Index: test/benchmarks/testcfg.py
diff --git a/test/benchmarks/testcfg.py b/test/benchmarks/testcfg.py
index
51d852084dcbeeef59db5b8e5617a7d5eb5ca332..ab9d40fec5b763c3f545ef374e7e484ed73235c1
100644
--- a/test/benchmarks/testcfg.py
+++ b/test/benchmarks/testcfg.py
@@ -91,7 +91,7 @@ class BenchmarkTestConfiguration(test.TestConfiguration):
return [test]
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
pass
Index: test/es5conform/testcfg.py
diff --git a/test/es5conform/testcfg.py b/test/es5conform/testcfg.py
index
af74b8c5205f427f2697a2a4ddebb8d15d56941e..b6a17d9b690ca8408646d4f903c882d1a22d3524
100644
--- a/test/es5conform/testcfg.py
+++ b/test/es5conform/testcfg.py
@@ -97,7 +97,7 @@ class ES5ConformTestConfiguration(test.TestConfiguration):
return tests
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'es5conform.status')
Index: test/message/testcfg.py
diff --git a/test/message/testcfg.py b/test/message/testcfg.py
index
aabbfef9b032c2f9f6ea21d821fb0600998d3e3a..af467e699eddae90fc10aa4551f4c18cf86baf8c
100644
--- a/test/message/testcfg.py
+++ b/test/message/testcfg.py
@@ -125,7 +125,7 @@ class MessageTestConfiguration(test.TestConfiguration):
return result
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'message.status')
Index: test/mjsunit/testcfg.py
diff --git a/test/mjsunit/testcfg.py b/test/mjsunit/testcfg.py
index
7c6311b1a722e58f1ac6ccaf184d73b50a83e823..87ed4fae8fb8c3fc394a09b1c7259a864f470755
100644
--- a/test/mjsunit/testcfg.py
+++ b/test/mjsunit/testcfg.py
@@ -145,7 +145,7 @@ class MjsunitTestConfiguration(test.TestConfiguration):
return result
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'mjsunit.status')
Index: test/mozilla/testcfg.py
diff --git a/test/mozilla/testcfg.py b/test/mozilla/testcfg.py
index
3728f7900ba263d8e063b44843abd6c355d119ae..587781d11f24abf747d7948268c66832e924e32c
100644
--- a/test/mozilla/testcfg.py
+++ b/test/mozilla/testcfg.py
@@ -125,7 +125,7 @@ class MozillaTestConfiguration(test.TestConfiguration):
return tests
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'mozilla.status')
Index: test/sputnik/testcfg.py
diff --git a/test/sputnik/testcfg.py b/test/sputnik/testcfg.py
index
c9eb4f2150d5fabb1077f496a14709cd1bb48926..1032c134f625a97207bf83ea1f71c87800bf7c4b
100644
--- a/test/sputnik/testcfg.py
+++ b/test/sputnik/testcfg.py
@@ -101,7 +101,7 @@ class SputnikTestConfiguration(test.TestConfiguration):
return result
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'sputnik.status')
Index: test/test262/testcfg.py
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
index
aa1212e48f31696720631d2f5613022a7b303f84..948204603443d2b060f2cb761fc21edd6472f799
100644
--- a/test/test262/testcfg.py
+++ b/test/test262/testcfg.py
@@ -111,7 +111,7 @@ class Test262TestConfiguration(test.TestConfiguration):
return tests
def GetBuildRequirements(self):
- return ['sample', 'sample=shell']
+ return ['d8']
def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'test262.status')
Index: tools/test.py
diff --git a/tools/test.py b/tools/test.py
index
d09f275e5be2ee374416bc12bf5052d36288b550..29eae620298af999b0e4c48762be99b9c6f052b5
100755
--- a/tools/test.py
+++ b/tools/test.py
@@ -1208,7 +1208,7 @@ def BuildOptions():
dest="suppress_dialogs", default=True, action="store_true")
result.add_option("--no-suppress-dialogs", help="Display Windows dialogs
for crashing tests",
dest="suppress_dialogs", action="store_false")
- result.add_option("--shell", help="Path to V8 shell", default="shell")
+ result.add_option("--shell", help="Path to V8 shell", default="d8")
result.add_option("--isolates", help="Whether to test isolates",
default=False, action="store_true")
result.add_option("--store-unexpected-output",
help="Store the temporary JS files from tests that fails",
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
