LGTM with comments.
http://codereview.chromium.org/7285001/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7285001/diff/1/src/hydrogen.cc#newcode3939 src/hydrogen.cc:3939: if (elements_kind == JSObject::DICTIONARY_ELEMENTS + 1 How about a static assert that verifies that DICTIONARY_ELEMENTS + 1 will actually get visited in this look, like STATIC_CHECK(JSObject::DICTIONARY_ELEMENTS + 1 <= JSObject::LAST_ELEMENTS_KIND) Actually, even better, why not compare against FIRST_EXTERNAL_ARRAY_ELEMENTS_KIND and STATIC_CHECK(JSObject::LAST_ELEMENTS_KIND == JSObject::LAST_EXTERNAL_ARRAY_ELEMENTS_KIND)? It think that's actually what you want. http://codereview.chromium.org/7285001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
