LGTM
http://codereview.chromium.org/7283006/diff/2001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/7283006/diff/2001/src/ia32/full-codegen-ia32.cc#newcode3550 src/ia32/full-codegen-ia32.cc:3550: __ mov(ecx, FieldOperand(eax, JSFunction::kSharedFunctionInfoOffset)); I know that we explicitly check for this at the call sites (in array.js and string.js). But shouldn't we have a check for what we actually have in eax to guarantee that it is a JSFunction. http://codereview.chromium.org/7283006/diff/2001/src/ia32/full-codegen-ia32.cc#newcode3558 src/ia32/full-codegen-ia32.cc:3558: __ j(not_equal, if_true); You could consider having just one test instructions (non-byte version) with (1 << SharedFunctionInfo::kNative & 1 << SharedFunctionInfo::kStrictModeFunction) http://codereview.chromium.org/7283006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
