LGTM.
http://codereview.chromium.org/7237024/diff/14021/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7237024/diff/14021/src/hydrogen.cc#newcode2118 src/hydrogen.cc:2118: ReturnValue(owner()->Pop()); No need for this last line. All it does is check Phi(true, false) to make sure it's not the arguments value and then pushes it back on the environment. http://codereview.chromium.org/7237024/diff/14021/src/hydrogen.cc#newcode3006 src/hydrogen.cc:3006: return ast_context()->ReturnInstruction(instr, expr->id()); :) http://codereview.chromium.org/7237024/diff/14021/src/hydrogen.h File src/hydrogen.h (right): http://codereview.chromium.org/7237024/diff/14021/src/hydrogen.h#newcode501 src/hydrogen.h:501: virtual void ReturnControl(HControlInstruction* instr, int ast_id) = 0; Needs a comment in similar detail to ReturnValue and ReturnInstruction. http://codereview.chromium.org/7237024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
