LGTM with comments.
http://codereview.chromium.org/7289010/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7289010/diff/1/src/runtime.cc#newcode12478 src/runtime.cc:12478: On 2011/06/30 08:54:49, yangguo wrote:
I hope adding yet another macro is alright. Saves a lot of repetitive
code. The macro is OK. I would prefer to make this specific to the elements type for now. Call the macro ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION that are of the form that supports a definition list of the following form: ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION(FastElements); ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION(FastDoubleElements); .... http://codereview.chromium.org/7289010/diff/1/src/runtime.h File src/runtime.h (right): http://codereview.chromium.org/7289010/diff/1/src/runtime.h#newcode340 src/runtime.h:340: F(ObjectHasFastElements, 1, 1) \ Is there any reason that you don't call these HasXXX rather than ObjectHasXXX? Names without the Object prefix are more consistent with other functions like HasProperty or HasElement. http://codereview.chromium.org/7289010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
