LGTM
http://codereview.chromium.org/7285030/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7285030/diff/1/src/runtime.cc#newcode5771 src/runtime.cc:5771: indices->Add(pos++ - subject_start); Don't do side-effects inside an argument. Just put 'pos++;' or 'pos += 1;' on the next line. http://codereview.chromium.org/7285030/diff/1/src/runtime.cc#newcode5775 src/runtime.cc:5775: StringSearch<PatternChar, SubjectChar> search(isolate, pattern); StringSearch::Search does use memchr for this case too, so we are only saving the call overhead. http://codereview.chromium.org/7285030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
