http://codereview.chromium.org/7310025/diff/1/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/7310025/diff/1/src/runtime.cc#newcode12160 src/runtime.cc:12160: I don't think that specialized testing functions like CreateClassWithCallback and CreateClassWithGetterAndSetter realy belong in runtime.cc. Please rewrite the tests using these as cctests. http://codereview.chromium.org/7310025/diff/1/src/runtime.cc#newcode12217 src/runtime.cc:12217: RUNTIME_FUNCTION(MaybeObject*, Runtime_CollectGarbage2) { I don't see any difference between this and the existing Runtime_CollectGarbage. http://codereview.chromium.org/7310025/diff/1/test/mjsunit/log-eq-of-logging-and-traversal.js File test/mjsunit/log-eq-of-logging-and-traversal.js (right): http://codereview.chromium.org/7310025/diff/1/test/mjsunit/log-eq-of-logging-and-traversal.js#newcode35 test/mjsunit/log-eq-of-logging-and-traversal.js:35: Please add a comment here to explain that first the normal logging is used (as profiling is turned on) and then the traversal one normally used when starting logging is used. http://codereview.chromium.org/7310025/diff/1/test/mjsunit/log-eq-of-logging-and-traversal.js#newcode140 test/mjsunit/log-eq-of-logging-and-traversal.js:140: if (!entityA && entityB) return true; !entityA -> entityA == null? http://codereview.chromium.org/7310025/diff/1/test/mjsunit/log-eq-of-logging-and-traversal.js#newcode141 test/mjsunit/log-eq-of-logging-and-traversal.js:141: if (entityA && !entityB) return false; Ditto. http://codereview.chromium.org/7310025/diff/1/test/mjsunit/log-eq-of-logging-and-traversal.js#newcode147 test/mjsunit/log-eq-of-logging-and-traversal.js:147: var equal = true; Please explain how this comparison works, and why there are more data in logging_entries. http://codereview.chromium.org/7310025/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
