lgtm
http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc#newcode5167 src/x64/code-stubs-x64.cc:5167: // branch when we start and stop incremental heap marking. This comment does not mention compaction. I would suggest 'generated with a label' rather than 'generated as a label' http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc#newcode5185 src/x64/code-stubs-x64.cc:5185: // it was added to a stub cache. This looks nasty. Please file a bug and put the bug number in here. One way may be to patch again just after it is added to the stub. http://codereview.chromium.org/7322012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
