Could anybody fill me in on how to use the linux tick processor? As far as I can see there is only a problem if we need d8 to be compiled for shared library and have js arguments available at the same time. Currently there seems to be no such problem since the sample shell does not take js arguments and d8 does not compile with shared library.
If shared library and js arguments have to work together, we could still resort into packing stuff from v8::internal into a wrapper and expose it in the shared library. Cheers, Yang On Sat, Jul 9, 2011 at 9:58 AM, Rico Wind <[email protected]> wrote: > [+v8-team] (maybe other people have additional input) > > Comments inline below > > On Fri, Jul 8, 2011 at 4:51 PM, Yang Guo <[email protected]> wrote: > > Hi Rico and Soren, > > I investigated a little bit on how to make d8 compatible with shared > > library. It struck me that we need a d8 that works with shared library > only > > as a test platform to run test cases, which is what the sample shell has > > been providing so far. > > d8 is heavily involved with stuff from v8::internal, but only for fancy > > stuff. If I remove those for when compiling with shared library, we would > > have a d8 with fancy features when compiled as static, but also a d8 > without > > fancy features that works with shared library. > > I suggest removing the following features from d8 when compiling for > shared > > library (using preprocessor flags). > > - multithreading (including isolates) > > - javascript arguments > Don't we use this for the linux-tick-processor, i.e., we should > probably make it somehow clear that if people use d8 with shared > library to profile, they need to rebuild d8 without shared before > running the tick-processor (or change the tick-processor script to > check if the file is compiled with shared library in which case we > could recompile - although people might not notice and think that > their copy is still with shared library). > > - counters > > - code completion > > - javascript debugger > > Those features don't exist in the sample shell in the first place, or at > > least - in the case of isolates - does not exist in the sample shell when > > built with shared library. > I think leaving these out when compiling for shared library is OK, if > we can make it clear for users it would even better (e.g., exit with > an error that the given flags are not supported when running in shared > library mode). > > > I assume that we do not support building with shared library on Windows, > > therefore I can bypass the indirection layer with v8::internal::OS for > > reading from file or from stdin when building with shared library. > As far as I know, we do actually support shared library on windows > (Søren will know). > > Cheers, > Rico > > > That way d8 would be completely free of v8::internal when V8_SHARED or > > USING_V8_SHARED is set. > > Thoughts? > > Cheers, > > Yang > > > > > > > > On Fri, Jul 8, 2011 at 11:43 AM, Yang Guo <[email protected]> wrote: > >> > >> Rico, > >> alright. Switching to d8 has been on low priority anyways, waiting > another > >> week won't hurt. > >> Cheers, > >> Yang > >> > >> On Fri, Jul 8, 2011 at 11:41 AM, Rico Wind <[email protected]> wrote: > >>> > >>> Yang, > >>> > >>> Sounds good, I suggest that we put of switching to d8 as default then, > >>> we really need the shared builder, this is causing issues for linux > >>> distros and node.js when we mess it up. > >>> > >>> Cheers, > >>> Rico > >>> > >>> On Fri, Jul 8, 2011 at 11:37 AM, Yang Guo <[email protected]> > wrote: > >>> > Rico, > >>> > d8 is heavily dependent on v8::internal, and this has been a known > >>> > issue > >>> > apparently: > >>> > http://groups.google.com/group/v8-users/msg/d247f87752efffec > >>> > Soren suggested to build a wrapper for the necessary v8::internal > stuff > >>> > into > >>> > v8/v8-testing.h or a stand-alone file. > >>> > How about we put off either switching to d8 or the shared library > >>> > builder/tester. After I land my CL on d8 --isolate I will try to get > d8 > >>> > ready for shared library so that ultimately we get both done? > >>> > Cheers, > >>> > Yang > >>> > > >>> > On Fri, Jul 8, 2011 at 11:29 AM, Rico Wind <[email protected]> > wrote: > >>> >> > >>> >> Yang, > >>> >> > >>> >> yes, it is not an issue today, but it will be next week :-( (I > >>> >> promised to put up a shared library builder/tester) > >>> >> > >>> >> Cheers, > >>> >> Rico > >>> >> > >>> >> On Fri, Jul 8, 2011 at 11:23 AM, Yang Guo <[email protected]> > >>> >> wrote: > >>> >> > Hi Rico, > >>> >> > I just found out that d8 cannot be linked with a shared V8 > library. > >>> >> > Will > >>> >> > that be a problem? > >>> >> > Cheers, > >>> >> > Yang > >>> >> > > >>> >> > On Thu, Jul 7, 2011 at 9:29 PM, Yang Guo <[email protected]> > >>> >> > wrote: > >>> >> >> > >>> >> >> Hi Rico, > >>> >> >> I'll just have to land those changes I made for D8 to support > >>> >> >> --isolate. > >>> >> >> As soon as that's done I will notify you to coordinate the > switch. > >>> >> >> Cheers, > >>> >> >> Yang > >>> >> >> > >>> >> >> On Thu, Jul 7, 2011 at 7:20 PM, Rico Wind <[email protected]> > >>> >> >> wrote: > >>> >> >>> > >>> >> >>> Yang, > >>> >> >>> > >>> >> >>> No, not really, but if we land it with enough support for > running > >>> >> >>> the > >>> >> >>> test suites I think we are good to go (still, we need to > >>> >> >>> coordinate > >>> >> >>> when we land the change to tools/test.py to make D8 default) > >>> >> >>> > >>> >> >>> Cheers, > >>> >> >>> Rico > >>> >> >>> > >>> >> >>> On Thu, Jul 7, 2011 at 6:17 PM, <[email protected]> wrote: > >>> >> >>> > I just finished porting --isolate to d8, still waiting for > code > >>> >> >>> > review > >>> >> >>> > though. > >>> >> >>> > In the meantime: can you think of any features that exist in > the > >>> >> >>> > sample > >>> >> >>> > shell, > >>> >> >>> > but not in d8? > >>> >> >>> > > >>> >> >>> > On 2011/06/30 09:41:58, yangguo wrote: > >>> >> >>> >> > >>> >> >>> >> Vitaly or Rico, > >>> >> >>> > > >>> >> >>> >> dropping me a line on how to use the sample shell with > >>> >> >>> >> --isolate > >>> >> >>> >> would > >>> >> >>> >> help me > >>> >> >>> > > >>> >> >>> > a > >>> >> >>> >> > >>> >> >>> >> lot, better yet, a test case. I'm currently porting that part > >>> >> >>> >> of > >>> >> >>> >> the > >>> >> >>> >> code > >>> >> >>> >> to > >>> >> >>> > > >>> >> >>> > d8. > >>> >> >>> > > >>> >> >>> >> Thanks! > >>> >> >>> > > >>> >> >>> >> Yang > >>> >> >>> > > >>> >> >>> >> On 2011/06/30 07:33:33, Rico wrote: > >>> >> >>> >> > As vitaly mentions, we need support for the --isolates flag > >>> >> >>> >> > (otherwise > >>> >> >>> >> > our > >>> >> >>> >> > isolates builder will become red) > >>> >> >>> >> > When that is fixed, LGTM ( I have already committed > >>> >> >>> >> > http://codereview.chromium.org/7218071/ so the buildbot is > >>> >> >>> >> > ready > >>> >> >>> >> > for > >>> >> >>> >> > a > >>> >> >>> > > >>> >> >>> > restart > >>> >> >>> >> > >>> >> >>> >> > when this has landed) > >>> >> >>> > > >>> >> >>> > > >>> >> >>> > > >>> >> >>> > http://codereview.chromium.org/7282008/ > >>> >> >>> > > >>> >> >> > >>> >> > > >>> >> > > >>> > > >>> > > >> > > > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
