LGTM with nits
http://codereview.chromium.org/7331014/diff/1/src/mips/regexp-macro-assembler-mips.h File src/mips/regexp-macro-assembler-mips.h (right): http://codereview.chromium.org/7331014/diff/1/src/mips/regexp-macro-assembler-mips.h#newcode34 src/mips/regexp-macro-assembler-mips.h:34: #include "macro-assembler.h" Please include in alpabetical order: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Order_of_Includes http://codereview.chromium.org/7331014/diff/1/src/x64/regexp-macro-assembler-x64.h File src/x64/regexp-macro-assembler-x64.h (right): http://codereview.chromium.org/7331014/diff/1/src/x64/regexp-macro-assembler-x64.h#newcode35 src/x64/regexp-macro-assembler-x64.h:35: #include "x64/macro-assembler-x64.h" alphabetize http://codereview.chromium.org/7331014/diff/1/test/cctest/test-regexp.cc File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/7331014/diff/1/test/cctest/test-regexp.cc#newcode45 test/cctest/test-regexp.cc:45: #include "code.h" alphabetize http://codereview.chromium.org/7331014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
