What happened if you used IgnoreAttributesAndSetProperty? Did it not call the
FunctionSetPrototype setter? Was the assignment just ignored?


http://codereview.chromium.org/7324027/diff/1/src/apinatives.js
File src/apinatives.js (right):

http://codereview.chromium.org/7324027/diff/1/src/apinatives.js#newcode81
src/apinatives.js:81: %IgnoreAttributesAndSetProperty(fun, "prototype",
{}, attributes);
Let's create a runtime function %SetPropertyAttributes that changes the
attributes of a property after the fact instead of using this one.

The issue here is that the prototype property is not a normal property
but an accessor that extracts the value from a field in the map. How
does the code you had before fail?

http://codereview.chromium.org/7324027/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7324027/diff/1/src/objects.cc#newcode2409
src/objects.cc:2409: // Note that this method cannot be used to set the
prototype of a function (it
If you want a note here I think it should explain exactly why it fails
instead of just stating that it fails.

http://codereview.chromium.org/7324027/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to