http://codereview.chromium.org/7334010/diff/1/src/platform-posix.cc File src/platform-posix.cc (right):
http://codereview.chromium.org/7334010/diff/1/src/platform-posix.cc#newcode137 src/platform-posix.cc:137: if (fstat(fileno(file), &file_stat) == 0 && (file_stat.st_mode & S_IFREG)) Omit braces only for one-liners. Do not use ints as boolean values. Introduce an explaining variable is_regular_file (http://www.refactoring.com/catalog/introduceExplainingVariable.html). Guard clauses are easier to read than nested conditionals (http://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html). http://codereview.chromium.org/7334010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
