LGTM.
http://codereview.chromium.org/7298003/diff/3001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/7298003/diff/3001/src/hydrogen-instructions.h#newcode2401 src/hydrogen-instructions.h:2401: explicit HJSArrayLength(HValue* value, HValue* typecheck) No need for explicit. http://codereview.chromium.org/7298003/diff/3001/src/hydrogen-instructions.h#newcode2409 src/hydrogen-instructions.h:2409: SetFlag(kDependsOnMaps); I'm not positive we need this flag anymore, because it depends only on the map that it's checking. Everything should be made to work if we remove this flag. That would enable moving/eliminating this instruction in the case that some unrelated map has changed. The code as written is safe, so leave it as is and we can talk about changing it when everyone gets back from vacation. http://codereview.chromium.org/7298003/diff/3001/src/hydrogen-instructions.h#newcode3438 src/hydrogen-instructions.h:3438: explicit HLoadElements(HValue* value, HValue* typecheck) Same, no need for explicit. http://codereview.chromium.org/7298003/diff/3001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7298003/diff/3001/src/hydrogen.cc#newcode3267 src/hydrogen.cc:3267: elements = new(zone()) HLoadElements(literal, literal); The second occurrence of literal is used as a token to indicate that you've discharged your obligation to check this map ("trust me, I know what I'm doing"). I wonder if the undefined value or something is better to use here? http://codereview.chromium.org/7298003/diff/3001/src/hydrogen.cc#newcode3983 src/hydrogen.cc:3983: new(zone()) HLoadElements(object, elements_kind_branch)); Should we assert the check instruction is not NULL here? http://codereview.chromium.org/7298003/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
