LGTM
http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode125 src/code-stubs.cc:125: heap->incremental_marking()->ActivateGeneratedStub(code); Seems like the wrong direction of dependency, to make the CodeStub superclass know about a specific kind of subclass. How about calling a virtual callback function on the stub that only do something if it's needed. http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode165 src/code-stubs.cc:165: } else if (MajorKey() == RecordWrite) { Again, create a virtual function, e.g., MustBeCached(), that returns true on the RecordWrite stub. http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode172 src/code-stubs.cc:172: heap->incremental_marking()->ActivateGeneratedStub(code); And again. http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc#newcode310 src/incremental-marking.cc:310: RecordWriteStub::STORE_BUFFER_ONLY); Indent to '(' or four chars from start of statement, not four chars from '('. http://codereview.chromium.org/7329049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
