Reviewers: danno, Søren Gjesse,
Description:
Fixed a long-standing TODO: Removed a few *-incl.h #includes from isolate.h.
ZoneAllocationPolicy::New is not inlined anymore because this pulls in far
too
much stuff and doesn't really make any measurable performance difference.
And
no, the #includes are still not in alphabetical order... ;-)
Please review this at http://codereview.chromium.org/7346006/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/allocation.h
M src/debug.h
M src/frames.cc
M src/isolate.h
M src/scopeinfo.cc
M src/scopes.cc
M src/string-stream.cc
M src/type-info.h
M src/zone.h
Index: src/allocation.h
===================================================================
--- src/allocation.h (revision 8614)
+++ src/allocation.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright 2008 the V8 project authors. All rights reserved.
+// Copyright 2008-2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -28,6 +28,7 @@
#ifndef V8_ALLOCATION_H_
#define V8_ALLOCATION_H_
+#include "allocation.h"
#include "checks.h"
#include "globals.h"
Index: src/debug.h
===================================================================
--- src/debug.h (revision 8614)
+++ src/debug.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2006-2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -35,6 +35,7 @@
#include "execution.h"
#include "factory.h"
#include "flags.h"
+#include "frames-inl.h"
#include "hashmap.h"
#include "platform.h"
#include "string-stream.h"
Index: src/frames.cc
===================================================================
--- src/frames.cc (revision 8614)
+++ src/frames.cc (working copy)
@@ -36,6 +36,8 @@
#include "scopeinfo.h"
#include "string-stream.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
Index: src/isolate.h
===================================================================
--- src/isolate.h (revision 8614)
+++ src/isolate.h (working copy)
@@ -1356,10 +1356,4 @@
} } // namespace v8::internal
-// TODO(isolates): Get rid of these -inl.h includes and place them only
where
-// they're needed.
-#include "allocation-inl.h"
-#include "zone-inl.h"
-#include "frames-inl.h"
-
#endif // V8_ISOLATE_H_
Index: src/scopeinfo.cc
===================================================================
--- src/scopeinfo.cc (revision 8614)
+++ src/scopeinfo.cc (working copy)
@@ -32,6 +32,8 @@
#include "scopeinfo.h"
#include "scopes.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
Index: src/scopes.cc
===================================================================
--- src/scopes.cc (revision 8614)
+++ src/scopes.cc (working copy)
@@ -34,6 +34,8 @@
#include "prettyprinter.h"
#include "scopeinfo.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
Index: src/string-stream.cc
===================================================================
--- src/string-stream.cc (revision 8614)
+++ src/string-stream.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2006-2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -30,6 +30,8 @@
#include "factory.h"
#include "string-stream.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
Index: src/type-info.h
===================================================================
--- src/type-info.h (revision 8614)
+++ src/type-info.h (working copy)
@@ -30,7 +30,6 @@
#include "allocation.h"
#include "globals.h"
-#include "zone.h"
#include "zone-inl.h"
namespace v8 {
Index: src/zone.h
===================================================================
--- src/zone.h (revision 8614)
+++ src/zone.h (working copy)
@@ -164,7 +164,7 @@
class ZoneListAllocationPolicy {
public:
// Allocate 'size' bytes of memory in the zone.
- INLINE(static void* New(int size));
+ static void* New(int size);
// De-allocation attempts are silently ignored.
static void Delete(void* p) { }
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
