http://codereview.chromium.org/7321006/diff/1/include/v8.h File include/v8.h (right):
http://codereview.chromium.org/7321006/diff/1/include/v8.h#newcode1439 include/v8.h:1439: * Gets the property attributes of a property. You should document that this returns None if the property is not present and otherwise returns the property attributes of the existing property. http://codereview.chromium.org/7321006/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/7321006/diff/1/src/api.cc#newcode2723 src/api.cc:2723: i::Handle<i::String> name = i::Handle<i::String>::cast(key_obj); This will not work if you pass in some other object than a string (such as a number or object). You should handle this in the same way that Object::Get is handled. You need to convert the key to a string if it isn't already. http://codereview.chromium.org/7321006/diff/1/src/api.cc#newcode2725 src/api.cc:2725: has_pending_exception = (result == ABSENT); Let's not misuse has_pending_exception for this. Just have the EXCEPTION_BAILOUT_CHECK here. Then after that return static_cast<PropertyAttribute>(NONE) if result is ABSENT. http://codereview.chromium.org/7321006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
