http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right):
http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc#newcode541 src/incremental-marking.cc:541: if (!FLAG_incremental_marking_steps) return; Are FLAG_incremental_marking and FLAG_incremental_marking_steps forced to be dependent in any way? Should they be (i.e., it seems it should be sufficient to check FLAG_incremental_marking_steps)? http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc#newcode542 src/incremental-marking.cc:542: if (state_ != SWEEPING && state_ != MARKING) return; How about combining all these conditions with || and just having one return? http://codereview.chromium.org/7324049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
