http://codereview.chromium.org/7343005/diff/1/src/deoptimizer.h File src/deoptimizer.h (right):
http://codereview.chromium.org/7343005/diff/1/src/deoptimizer.h#newcode723 src/deoptimizer.h:723: class ScopedDeoptimizedFrameInfo { This class looks a bits strange: If the frame passed to the constructor is not optimized, every single method call would segfault, meaning that the constructed object is illegal from a semantical point of view. Therefore, it shouldn't be possible to construct such an instance in the first place. The test should probably be moved to the caller or, alternatively, a null object pattern should be used. http://codereview.chromium.org/7343005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
