drive by comments.
http://codereview.chromium.org/7307030/diff/12005/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/7307030/diff/12005/src/arm/stub-cache-arm.cc#newcode4208 src/arm/stub-cache-arm.cc:4208: __ add(r5, r4, Operand(1), SetCC); 0x7FFFFFFF + 1 will not set the overflow flag, but the negative flag. Some negative values are valid for the upper part of a double so maybe a cmp could be used instead. The V8 assembler will replace cmp with 0x7FFFFFFF by cmn with 0x80000001 and 0x80000001 is a valid ARM immediate (no need for extra instructions). http://codereview.chromium.org/7307030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
