Agreed. -- Vyacheslav Egorov On Tue, Jul 12, 2011 at 5:05 PM, <[email protected]> wrote:
> > http://codereview.chromium.**org/7349005/diff/4001/src/**objects.cc<http://codereview.chromium.org/7349005/diff/4001/src/objects.cc> > File src/objects.cc (right): > > http://codereview.chromium.**org/7349005/diff/4001/src/** > objects.cc#newcode11535<http://codereview.chromium.org/7349005/diff/4001/src/objects.cc#newcode11535> > src/objects.cc:11535: MaybeObject* > ObjectDictionary::AddChecked(**JSObject* key, Object* value) { > Maybe we can come up with a better name once we actually use it aside > from the unit test. > > > On 2011/07/12 13:30:32, Vyacheslav Egorov wrote: > >> AddChecked is a bit confusing name but I can't invent a better name. >> HashKeyAndAdd might be better but it's still pretty confusing. >> > > http://codereview.chromium.**org/7349005/<http://codereview.chromium.org/7349005/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
