http://codereview.chromium.org/7344013/diff/1/include/v8.h File include/v8.h (right):
http://codereview.chromium.org/7344013/diff/1/include/v8.h#newcode937 include/v8.h:937: V8EXPORT bool IsBoxedBoolean() const; Lets call them IsXXXObject instead of IsBoxedXXX. http://codereview.chromium.org/7344013/diff/1/include/v8.h#newcode1778 include/v8.h:1778: class BoxedNumber : public Object { XXXObject http://codereview.chromium.org/7344013/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/7344013/diff/1/src/api.cc#newcode2228 src/api.cc:2228: bool Value::IsMath() const { Lets pull IsMath() from API for now. http://codereview.chromium.org/7344013/diff/1/src/factory.cc File src/factory.cc (right): http://codereview.chromium.org/7344013/diff/1/src/factory.cc#newcode249 src/factory.cc:249: isolate->heap()->AllocateJSObject(constructor), constructor will be "dead variable" if GC happens. you need to wrap constructor into Handle. (constructor object can't die, but potentially can be relocated) better still: there is already a Object::ToObject and Factory::ToObject methods which do exactly what you need. So I think you can use them to implement your API. so Factory::NewBoxedXXX are unnecessary. http://codereview.chromium.org/7344013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
