Reviewers: Lasse Reichstein,
Description:
Chang Heap::FreeQueuedChunks to prepare queued large chunks for
StoreBuffer::Filter.
We split large chunks into separate smaller kPageSize aligned pieces to
ensure
that
MemoryChunk::FromAnyPointerAddress would be able to find chunk containing
slot
even if the chunk was unlinked from the list of large chunks.
[email protected]
BUG=v8:1554
Please review this at http://codereview.chromium.org/7356005/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
0e3a8d501bb6a283bcf5eecb274f8fd511bec5c4..40a1c72694f90bf6bf8f2f16e74dc65e13fa5637
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -5975,6 +5975,28 @@ void Heap::FreeQueuedChunks() {
for (chunk = chunks_queued_for_free_; chunk != NULL; chunk = next) {
next = chunk->next_chunk();
chunk->SetFlag(MemoryChunk::ABOUT_TO_BE_FREED);
+
+ if (chunk->owner()->identity() == LO_SPACE) {
+ // StoreBuffer::Filter relies on MemoryChunk::FromAnyPointerAddress.
+ // If FromAnyPointerAddress encounters a slot that belongs to a large
+ // chunk queued for deletion it will fail to find the chunk because
+ // it try to perform a search in the list of pages owned by of the
large
+ // object space and queued chunks were detached from that list.
+ // To work around this we split large chunk into normal kPageSize
aligned
+ // pieces and initialize owner field and flags of every piece.
+ // If FromAnyPointerAddress encounteres a slot that belongs to one of
+ // these smaller pieces it will treat it as a slot on a normal Page.
+ MemoryChunk* inner = MemoryChunk::FromAddress(
+ chunk->address() + Page::kPageSize);
+ MemoryChunk* inner_last = MemoryChunk::FromAddress(
+ chunk->address() + chunk->size() - 1);
+ while (inner <= inner_last) {
+ inner->set_owner(lo_space());
+ inner->SetFlag(MemoryChunk::ABOUT_TO_BE_FREED);
+ inner = MemoryChunk::FromAddress(
+ inner->address() + Page::kPageSize);
+ }
+ }
}
isolate_->heap()->store_buffer()->Filter(MemoryChunk::ABOUT_TO_BE_FREED);
for (chunk = chunks_queued_for_free_; chunk != NULL; chunk = next) {
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
