LGTM.

http://codereview.chromium.org/7350015/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/7350015/diff/1/src/arm/lithium-codegen-arm.cc#newcode1516
src/arm/lithium-codegen-arm.cc:1516: __ nop();  // Signals no inlined
code.
Is it at all possible to create something like CallBinaryOpStub to
ensure that a nop or the correct test always gets inserted? Seems like
we should try to make it very difficult to forget to insert the nop.

http://codereview.chromium.org/7350015/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to