---------- Forwarded message ---------- From: William Hesse <[email protected]> Date: Wed, Jul 13, 2011 at 9:57 PM Subject: Re: buildbot failure in Chromium Memory on Linux Tests (valgrind)(4), revision 92371 To: Jochen Eisinger <[email protected]>, William Hesse <[email protected]>, v8-dev <[email protected]> Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
This Valgrind error looks like it is probably ours (V8). Can it be suppressed, so we can fix it tomorrow? The trace is: 11:48:51 memcheck_analyze.py [ERROR] FAIL! There were 1 errors: 11:48:51 memcheck_analyze.py [ERROR] Command: /mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-4/build/src/sconsbuild/Release/chrome --type=zygote --log-level=1 --enable-logging --noerrdialogs --user-data-dir=/tmp/.org.chromium.Chromium.exEshI InvalidWrite Invalid write of size 4 WebCore::V8EntryCallback::handleEvent(WebCore::Entry*) (out/Release/obj/gen/webcore/bindings/V8EntryCallback.cpp:68) WebCore::EntryCallbacks::didSucceed() (third_party/WebKit/Source/WebCore/fileapi/FileSystemCallbacks.cpp:134) WebKit::WebFileSystemCallbacksImpl::didSucceed() (third_party/WebKit/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:65) WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread(WebCore::ScriptExecutionContext*, WebKit::WorkerFileSystemCallbacksBridge*) (third_party/WebKit/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:366) WebCore::CrossThreadTask1<WebKit::WorkerFileSystemCallbacksBridge*, WebKit::WorkerFileSystemCallbacksBridge*>::performTask(WebCore::ScriptExecutionContext*) (third_party/WebKit/Source/WebCore/dom/CrossThreadTask.h:81) WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread(WebCore::ScriptExecutionContext*, WTF::PassRefPtr<WebKit::WorkerFileSystemCallbacksBridge>, WTF::PassOwnPtr<WebCore::ScriptExecutionContext::Task>) (third_party/WebKit/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:395) WebCore::CrossThreadTask2<WTF::PassRefPtr<WebKit::WorkerFileSystemCallbacksBridge>, WTF::PassRefPtr<WebKit::WorkerFileSystemCallbacksBridge>, WTF::PassOwnPtr<WebCore::ScriptExecutionContext::Task>, WTF::PassOwnPtr<WebCore::ScriptExecutionContext::Task> >::performTask(WebCore::ScriptExecutionContext*) (third_party/WebKit/Source/WebCore/dom/CrossThreadTask.h:112) WebCore::WorkerRunLoop::Task::performTask(WebCore::ScriptExecutionContext*) (third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:199) WebCore::WorkerRunLoop::runInMode(WebCore::WorkerContext*, WebCore::ModePredicate const&) (third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:163) WebCore::WorkerRunLoop::run(WebCore::WorkerContext*) (third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:134) WebCore::WorkerThread::runEventLoop() (third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:163) WebCore::DedicatedWorkerThread::runEventLoop() (third_party/WebKit/Source/WebCore/workers/DedicatedWorkerThread.cpp:66) WebCore::WorkerThread::workerThread() (third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:141) WebCore::WorkerThread::workerThreadStart(void*) (third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:118) WTF::threadEntryPoint(void*) (third_party/WebKit/Source/JavaScriptCore/wtf/Threading.cpp:67) start_thread (/build/buildd/eglibc-2.11.1/nptl/pthread_create.c:300) On Wed, Jul 13, 2011 at 8:48 PM, <[email protected]> wrote: > > http://build.chromium.org/p/chromium.memory/ > > Failure notification for "memory test: ui_1" on "Linux Tests (valgrind)(4)". > Please see if the failures are related to your commit and take appropriate > actions (e.g. revert, update suppressions, notify sheriff, etc.). > > For more info on the memory waterfall please see these links: > http://dev.chromium.org/developers/how-tos/using-valgrind > http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff > > By the way, the current memory sheriff is on the CC list. > > http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/3151 > > Revision: 92362, 92364, 92365, 92366, 92367, 92368, 92369, 92370, 92371 > Blame list: > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > Linux Tests (valgrind)(4) > Build 3151 > update_scripts > stdio > update > r92371 > webkit r90915 > stdio > extract_build > stdio > memory test: googleurl > stdio > memory test: ipc > 1 disabled > stdio > memory test: media > stdio > memory test: printing > stdio > memory test: remoting > 5 disabled > 3 flaky > stdio > memory test: safe_browsing > stdio > memory test: sql > stdio > memory test: ui > 26 disabled > 67 flaky > stdio > memory test: ui > 26 disabled > 67 flaky > crashed or hung > stdio > B71F2123560FAD77 > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:00:30 > Branch: src > Revision: 92362 > Changed files: > > DEPS > > Comments: > > WebKit roll 90908:90915 > > TBR=scheib > BUG=None > TEST=None > > Review URL: http://codereview.chromium.org/7355021 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:03:50 > Branch: src > Revision: 92364 > Changed files: > > chrome/browser/automation/testing_automation_provider.cc > chrome/browser/extensions/convert_user_script.cc > chrome/browser/extensions/convert_user_script_unittest.cc > chrome/browser/extensions/convert_web_app_unittest.cc > chrome/browser/extensions/crx_installer.cc > chrome/browser/extensions/extension_management_api.cc > chrome/browser/extensions/extension_prefs.cc > chrome/browser/extensions/extension_prefs_unittest.cc > chrome/browser/extensions/extension_service_unittest.cc > chrome/browser/extensions/user_script_master.cc > chrome/browser/extensions/user_script_master_unittest.cc > chrome/common/extensions/extension.cc > chrome/common/extensions/extension.h > chrome/common/extensions/extension_manifests_unittest.cc > chrome/common/extensions/extension_messages.cc > chrome/common/extensions/extension_permission_set.cc > chrome/common/extensions/extension_permission_set.h > chrome/common/extensions/extension_permission_set_unittest.cc > chrome/common/extensions/extension_unittest.cc > chrome/common/extensions/file_browser_handler.h > chrome/common/extensions/url_pattern.cc > chrome/common/extensions/url_pattern.h > chrome/common/extensions/url_pattern_set.cc > chrome/common/extensions/url_pattern_set.h > chrome/common/extensions/url_pattern_set_unittest.cc > chrome/common/extensions/url_pattern_unittest.cc > chrome/common/extensions/user_script.cc > chrome/common/extensions/user_script.h > chrome/common/extensions/user_script_unittest.cc > chrome/renderer/extensions/extension_dispatcher.cc > chrome/renderer/extensions/user_script_slave.cc > > Comments: > > Update URLPatternSet to contain a std::set instead of std::vector. > > This updates URLPatternSet to contain a std::set instead of a std::vector, > making it easier to implement the set operations in ExtensionPermissionSet. > > BUG=84507 > TEST=unit_tests > > Review URL: http://codereview.chromium.org/7347011 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:13:10 > Branch: src > Revision: 92365 > Changed files: > > content/common/sandbox_mac_diraccess_unittest.mm > > Comments: > > Disables MacDirAccessSandboxTest.SandboxAccess as it keeps timing out. > > BUG=89710 > [email protected],[email protected] > > Review URL: http://codereview.chromium.org/7353019 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:27:50 > Branch: src > Revision: 92366 > Changed files: > > chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc > > Comments: > > Disables flaky test. > > [email protected] > BUG=89173 > TEST=none > > Review URL: http://codereview.chromium.org/7356015 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:35:40 > Branch: src > Revision: 92367 > Changed files: > > content/common/sandbox_mac.h > > Comments: > > Make disabled test not cause compile error. > > [email protected] > [email protected] > BUG=89170 > TEST= > > Review URL: http://codereview.chromium.org/7353020 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:46:10 > Branch: src > Revision: 92368 > Changed files: > > chrome/browser/first_run/first_run.cc > > Comments: > > Prevent users from bypassing the EULA shown on first run by killing setup.exe. > > BUG=88542 > TEST=NONE > Review URL: http://codereview.chromium.org/7250013 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:47:20 > Branch: src > Revision: 92369 > Changed files: > > chrome/browser/chromeos/login/webui_login_display.cc > > Comments: > > removed unused include > > BUG=none > TEST=none > > Review URL: http://codereview.chromium.org/7353002 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:50:50 > Branch: src > Revision: 92370 > Changed files: > > chrome/browser/renderer_host/render_widget_host_view_mac.h > chrome/browser/renderer_host/render_widget_host_view_mac.mm > chrome/browser/renderer_host/render_widget_host_view_views.cc > chrome/browser/renderer_host/render_widget_host_view_views.h > chrome/browser/tab_contents/tab_contents_view_mac.h > chrome/browser/tab_contents/tab_contents_view_mac.mm > > Comments: > > [Mac] Show correct cursor after context menu is closed. > > The fix has two parts to it. > > First keep the RenderViewContextMenu in a scoped_ptr on the > TabContentsViewMac instead of creating it on the stack in > |ShowContextMenu()|. (This is how it's done with views and gtk already.) This > ensures |MenuClosed()| gets called on the RenderViewContextMenu properly - > previously it would get destroyed before that could happen. > > Second, send mouse leave and mouse enter events to the renderer when the > context menu is opened and closed, so that the renderer will update the > cursor. > > The CL also renames |is_showing_popup_menu_| to |is_showing_context_menu_| in > the views code to be consistent with the name of the callback and the > equivalent variable in the GTK and now Mac code. > > BUG=64436 > TEST=see bug > > Review URL: http://codereview.chromium.org/7227007 > > Properties: > > Changed by: [email protected] > Changed at: Wed 13 Jul 2011 08:58:20 > Branch: src > Revision: 92371 > Changed files: > > DEPS > > Comments: > > Update V8 to version 3.4.12.1. > Review URL: http://codereview.chromium.org/7353018 > > Properties: -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
