Reviewers: danno, jkummerow,

Description:
Harmonize naming a bit, x64 was the only platform where Register::from_code was
called Register::toRegister.

Please review this at http://codereview.chromium.org/7364001/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/x64/assembler-x64.h
  M     src/x64/deoptimizer-x64.cc


Index: src/x64/assembler-x64.h
===================================================================
--- src/x64/assembler-x64.h     (revision 8647)
+++ src/x64/assembler-x64.h     (working copy)
@@ -125,7 +125,7 @@
     return names[index];
   }

-  static Register toRegister(int code) {
+  static Register from_code(int code) {
     Register r = { code };
     return r;
   }
Index: src/x64/deoptimizer-x64.cc
===================================================================
--- src/x64/deoptimizer-x64.cc  (revision 8647)
+++ src/x64/deoptimizer-x64.cc  (working copy)
@@ -643,7 +643,7 @@
   // We push all registers onto the stack, even though we do not need
   // to restore all later.
   for (int i = 0; i < kNumberOfRegisters; i++) {
-    Register r = Register::toRegister(i);
+    Register r = Register::from_code(i);
     __ push(r);
   }

@@ -801,12 +801,12 @@

   // Restore the registers from the stack.
   for (int i = kNumberOfRegisters - 1; i >= 0 ; i--) {
-    Register r = Register::toRegister(i);
+    Register r = Register::from_code(i);
     // Do not restore rsp, simply pop the value into the next register
     // and overwrite this afterwards.
     if (r.is(rsp)) {
       ASSERT(i > 0);
-      r = Register::toRegister(i - 1);
+      r = Register::from_code(i - 1);
     }
     __ pop(r);
   }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to