LGTM apart from tiny style issue.
http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript File test/cctest/SConscript (right): http://codereview.chromium.org/7354027/diff/1/test/cctest/SConscript#newcode37 test/cctest/SConscript:37: JS_FILES_FOR_TESTS = ''' Tiny style issue: JS_FILES_FOR_TESTS = [ 'blah', 'foo', ... ] would be more consistent that using split(). http://codereview.chromium.org/7354027/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev