http://codereview.chromium.org/7210057/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right):
http://codereview.chromium.org/7210057/diff/1/src/arm/assembler-arm.h#newcode1229 src/arm/assembler-arm.h:1229: static int NumRegistersInRegList(RegList list); On 2011/07/04 06:54:34, Erik Corry wrote:
frames.h already has int NumRegs(RegList list)
Done. http://codereview.chromium.org/7210057/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/7210057/diff/1/src/arm/stub-cache-arm.cc#newcode72 src/arm/stub-cache-arm.cc:72: value_off_addr - key_off_addr)); On 2011/07/04 06:54:34, Erik Corry wrote:
Strange indentation here. The value_off_addr should line up with the offsets_base_addr. Alternatively the MemOperand should line up with
the
scratch2.
Done. http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc#newcode171 src/ia32/stub-cache-ia32.cc:171: USE(extra2); // The register extra2 is not used on the ia32 platform. On 2011/07/04 07:21:19, Søren Gjesse wrote:
Will a USE(extra3) be needed to compile in release mode?
Done. http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc#newcode188 src/ia32/stub-cache-ia32.cc:188: ASSERT(!scratch.is(no_reg)); On 2011/07/04 07:21:19, Søren Gjesse wrote:
Also assert that extra is not no_reg?
extra can be no_reg here, eg. ic-ia32.cc:877. http://codereview.chromium.org/7210057/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/7210057/diff/1/src/x64/stub-cache-x64.cc#newcode162 src/x64/stub-cache-x64.cc:162: ASSERT(!scratch.is(no_reg)); On 2011/07/04 07:21:19, Søren Gjesse wrote:
Also assert that extra is no_reg?
extra can be no_reg here, eg. ic-x64.cc:765. http://codereview.chromium.org/7210057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
