LGTM with two comments addressed (sorry, troubles with our review tools). Nit: please, use two spaces after a period (before Also). Nit: remove the last blank line.
And thanks a lot. yours, anton. On Fri, Jun 24, 2011 at 1:14 PM, <[email protected]> wrote: > Reviewers: antonm, > > Description: > Update oom_dump README to indicate that people should build the correct V8 > version. > > Please review this at http://codereview.chromium.org/7198021/ > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M tools/oom_dump/README > > > Index: tools/oom_dump/README > =================================================================== > --- tools/oom_dump/README (revision 8401) > +++ tools/oom_dump/README (working copy) > @@ -16,7 +16,9 @@ > > Next step is to build v8. Note: you should build x64 version of v8, > if you're on 64-bit platform, otherwise you would get a link error when > -building oom_dump. > +building oom_dump. Also, if you are testing against an older version of > chrome > +you should build the corresponding version of V8 to make sure that the > type-id > +enum have the correct values. > > The last step is to build oom_dump itself. The following command should > work: > > @@ -29,3 +31,4 @@ > some useful information about the OOM crash. > > Note: currently only 32-bit Windows minidumps are supported. > + > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
