Thanks Slava. Addressed in http://codereview.chromium.org/7460009
http://codereview.chromium.org/7391001/diff/9002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7391001/diff/9002/src/objects.cc#newcode2310 src/objects.cc:2310: ASSERT(IsJSObject()); On 2011/07/19 04:07:57, Vyacheslav Egorov wrote:
self->IsJSObject() as we have GC above
Done. http://codereview.chromium.org/7391001/diff/9002/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7391001/diff/9002/src/runtime.cc#newcode622 src/runtime.cc:622: return proxy; On 2011/07/19 04:07:57, Vyacheslav Egorov wrote:
You are potentially returning invalid pointer here cause Fix can cause
a GC
(though it does not matter cause return value is ignored atm).
Better return undefined I think
Done. http://codereview.chromium.org/7391001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
