http://codereview.chromium.org/7436004/diff/1/src/v8natives.js File src/v8natives.js (right):
http://codereview.chromium.org/7436004/diff/1/src/v8natives.js#newcode613 src/v8natives.js:613: function CallTrap1(handler, name, x, defaultTrap) { On 2011/07/19 15:41:05, Mads Ager wrote:
Maybe put the arguments last in the parameter list so it is always:
(handler,
name, defaultTrap, arg0, ...).
Ahhh, the default trap is optional. Can we require it and explicitly
use "void
0" to pass undefined?
Done. http://codereview.chromium.org/7436004/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): http://codereview.chromium.org/7436004/diff/1/test/mjsunit/harmony/proxies.js#newcode496 test/mjsunit/harmony/proxies.js:496: TestHasOwn({ On 2011/07/19 15:41:05, Mads Ager wrote:
Add whitespace between the calls?
Done, here and elsewhere. http://codereview.chromium.org/7436004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
