LGTM with comments.
http://codereview.chromium.org/7473028/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): http://codereview.chromium.org/7473028/diff/1/src/code-stubs.cc#newcode341 src/code-stubs.cc:341: if (Contains(UNDEFINED)) stream->Add("Undefined"); Doesn't the lack of separation between types end up in unreadable strings in the output? http://codereview.chromium.org/7473028/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7473028/diff/1/src/ia32/code-stubs-ia32.cc#newcode316 src/ia32/code-stubs-ia32.cc:316: __ mov(eax, FieldOperand(eax, String::kLengthOffset)); eax -> tos_? http://codereview.chromium.org/7473028/diff/1/src/ia32/code-stubs-ia32.cc#newcode362 src/ia32/code-stubs-ia32.cc:362: __ cmp(eax, value); This should be duplicated in the two if branches so that the else at the bottom doesn't generate a spurious cmp. http://codereview.chromium.org/7473028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
