On Thu, Jul 21, 2011 at 5:07 PM, <[email protected]> wrote: > > http://codereview.chromium.org/7472029/diff/1/src/utils.h > File src/utils.h (right): > > http://codereview.chromium.org/7472029/diff/1/src/utils.h#newcode33 > src/utils.h:33: #include <climits> > On 2011/07/21 12:56:18, Vitaly Repeshko wrote: >> >> We include old school standard library headers without the "c" prefix > > (and the implied std:: namespace). > > That's not completely true, cstdio and cstdarg are already used. > >> Use <limits.h> to be consistent. > > To be consistent with the language used (C++), climits looks "more > correct" IMHO. ;-)
Well, grepping for climits gives 0 matches, whereas I get 10 for limits.h. Using climits here would not be consistent. Changing every standard header include to the "c" form could be done, but it will require using std:: prefixes in quite a few places. -- Vitaly -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
