Reviewers: danno, Description: Fixed an off-by-one error in SplitConstantsInFullCompiler test.
The test tried to disassemble the last entry in a constant pool, which only worked by accident until address randomization was introduced. Please review this at http://codereview.chromium.org/7489005/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-compiler.cc Index: test/cctest/test-compiler.cc =================================================================== --- test/cctest/test-compiler.cc (revision 8716) +++ test/cctest/test-compiler.cc (working copy) @@ -377,7 +377,7 @@ while (pc < end) { int num_const = d.ConstantPoolSizeAt(pc); if (num_const >= 0) { - pc += num_const * kPointerSize; + pc += (num_const + 1) * kPointerSize; } else { pc += d.InstructionDecode(decode_buffer, pc); CHECK(strstr(decode_buffer.start(), "mov eax,0x178c29c") == NULL); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
