> > > > I have tried to upload this for review with gcl but it failed. > > The first command seemed to work: > daniel@daniel-VirtualBox:~/v8$ gcl change mychange > WARNING: Creating CL in a read-only checkout. You will not be able to > commit it! > mychange changelist saved. > > But I get a warning when I try gcl upload: > daniel@daniel-VirtualBox:~/v8$ gcl upload mychange > Nothing to upload, changelist is empty. > > I'd like to know if I do something wrong with the gcl? > >
Thanks for the patch. You can try 'gcl opened mychange' to see which files are in your changelist. Maybe there is another changelist opened in the same directory? Also, did you already sign the contributor license agreement (CLA)? You will need to sign the CLA before to be able contribute to V8. You can find informations about it in our Wiki: http://code.google.com/p/v8/wiki/Contributing best regards, Florian > Best regards, > Daniel Marjamäki > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
