LGTM, consider adding a regression test for this

http://codereview.chromium.org/7497010/diff/2001/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3400
src/heap.cc:3400: maybe_elem =
Fits on one line

http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3770
src/heap.cc:3770: { MaybeObject* maybe_obj =
AllocateRawFixedDoubleArray(len,
Fits on one line

http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3776
src/heap.cc:3776: CopyBlock(dst->address() + kPointerSize,
Would it not be more correct to use FixedDoubleArray::kLengthOffset or
HeapObject::kHeaderSize, instead of just adding kPointerSize here

http://codereview.chromium.org/7497010/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to