http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h File src/code-stubs.h (right):
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h#newcode924 src/code-stubs.h:924: bool IsEmpty() const { return set_.IsEmpty(); } On 2011/07/27 14:49:38, Vitaly Repeshko wrote:
Maybe add IsAll()?
Done. http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h#newcode938 src/code-stubs.h:938: static Types all_types() { return Types(kAllTypes); } On 2011/07/27 14:46:33, Sven wrote:
Removing kAllTypes and directly using
(1 << NUMBER_OF_TYPES) - 1
in all_types() looks a bit cleaner, I think.
Done. http://codereview.chromium.org/7465066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
