http://codereview.chromium.org/7464030/diff/1/src/parser.cc File src/parser.cc (right):
http://codereview.chromium.org/7464030/diff/1/src/parser.cc#newcode2159 src/parser.cc:2159: if(catch_scope->calls_eval()) top_scope_->RecordEvalCall(); Style nit: there should be a space after the keyword if (also for, while, etc.) to visually distinguish it from a function call. http://codereview.chromium.org/7464030/diff/1/src/parser.cc#newcode2759 src/parser.cc:2759: top_scope_->RecordEvalCall(); I think it's more straightforward to do, instead, top_scope_->DeclarationScope()->RecordEvalCall() here. That avoids recording eval call for the potential try scope and we have only one call to Scope::RecordEvalCall exactly where needed. What do you think? http://codereview.chromium.org/7464030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
