LGTM

http://codereview.chromium.org/7385006/diff/15001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7385006/diff/15001/src/objects.h#newcode1646
src/objects.h:1646: // Makes sure to properly call BypassGlobalProxy to
be safe for JSGlobalProxy
I don't think the comments on proxies and fast properties are important.
Let's remove them.

http://codereview.chromium.org/7385006/diff/15001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7385006/diff/15001/src/runtime.cc#newcode4521
src/runtime.cc:4521: if (!GetHiddenProperties(jsproto,
JSObject::OMIT_CREATION)->IsUndefined()) {
Maybe we need HasHiddenProperties to simplify this?

http://codereview.chromium.org/7385006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to