I ported the code to ia32 and x64.
Note that I could not perform any tests for x64 as I do not have a 64-bit
machine handy.
Can you have a look at the use of LCodeGen::TokenToCondition in
LCodeGen::DoCmpIDAndBranch?
I fixed the use of 'instr->is_double()' for the 'is_unsigned' parameter on
ARM.
I do not know much about ia32 or x64 comparisons, but this looks dubious to
me.
Also, the comparison of two constants might be done at a higher level in
hydrogen. The compilation of unreachable blocks could even be avoided.
Thanks,
Alexandre
http://codereview.chromium.org/7489045/diff/1/src/arm/constants-arm.h
File src/arm/constants-arm.h (right):
http://codereview.chromium.org/7489045/diff/1/src/arm/constants-arm.h#newcode179
src/arm/constants-arm.h:179: inline bool EvalComparison(Condition cond,
double op1, double op2) {
On 2011/07/27 13:05:05, Mads Ager wrote:
Why not have this in the code generator and switch on the token
instead of going
from token to condition to operation?
Done.
http://codereview.chromium.org/7489045/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
