LGTM.
http://codereview.chromium.org/7538016/diff/1/test/mjsunit/undeletable-functions.js File test/mjsunit/undeletable-functions.js (left): http://codereview.chromium.org/7538016/diff/1/test/mjsunit/undeletable-functions.js#oldcode192 test/mjsunit/undeletable-functions.js:192: assertEquals("foo", type[prop], "overwritable: " + prop); I don't understand why we expected "foo" before :) It seems like someone could rewrite this test to use the ES5 reflective methods (e.g. Object.getOwnPropertyDescriptor). Presuming we have good test coverage of that and that we don't otherwise have special handling of these properties, that would be more direct. http://codereview.chromium.org/7538016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
