http://codereview.chromium.org/7389008/diff/1/src/heap.cc File src/heap.cc (right):
http://codereview.chromium.org/7389008/diff/1/src/heap.cc#newcode4995 src/heap.cc:4995: if (!ConfigureHeapDefault()) { Added to allow a breakpoint at the return. It's a simple change, so anyone needing it can reintroduce it, so I'll can revert it again. In fact, I'll revert the entire file. http://codereview.chromium.org/7389008/diff/1/src/heap.cc#newcode5109 src/heap.cc:5109: CHECK_EQ(isolate_, isolate()); This should probably have been ASSERT_EQ. http://codereview.chromium.org/7389008/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/7389008/diff/1/src/incremental-marking.cc#newcode435 src/incremental-marking.cc:435: intptr_t current = marking_deque_.bottom(); True, there is no need for intptr_t-ness here. http://codereview.chromium.org/7389008/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7389008/diff/1/src/mark-compact.cc#newcode3009 src/mark-compact.cc:3009: int MarkCompactCollector::SweepConservatively(PagedSpace* space, Page* p) { Should probably be size_t, but intptr_t will do (that's the type that the value is later added to). http://codereview.chromium.org/7389008/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7389008/diff/1/src/spaces.cc#newcode323 src/spaces.cc:323: } I added it in order to be able to make a breakpoint at the return. Will revert them all. http://codereview.chromium.org/7389008/diff/1/src/spaces.cc#newcode326 src/spaces.cc:326: static_cast<int>(OS::AllocateAlignment())); It's taking intptr_t for its second argument actually. That's what it's using internally when rounding. I'll fix the cast. http://codereview.chromium.org/7389008/diff/1/src/spaces.cc#newcode334 src/spaces.cc:334: return NULL; reverted. http://codereview.chromium.org/7389008/diff/1/src/spaces.cc#newcode671 src/spaces.cc:671: allocation_info_.top = reinterpret_cast<Address>(static_cast<uintptr_t>(2)); Sorry, leftover from debugging. Should be NULL again. http://codereview.chromium.org/7389008/diff/1/src/spaces.cc#newcode865 src/spaces.cc:865: if (base == NULL) { Curly-brace-ophobia is treatable. http://codereview.chromium.org/7389008/diff/1/src/store-buffer.h File src/store-buffer.h (right): http://codereview.chromium.org/7389008/diff/1/src/store-buffer.h#newcode87 src/store-buffer.h:87: static const int kOldStoreBufferLength = kStoreBufferLength * 16; No, out of memory error with larger value. http://codereview.chromium.org/7389008/diff/1/src/utils.h File src/utils.h (right): http://codereview.chromium.org/7389008/diff/1/src/utils.h#newcode123 src/utils.h:123: static inline T RoundUp(T x, intptr_t m) { I have fixed one - hope it's all. http://codereview.chromium.org/7389008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
