Could you add a regression test or is this already covered by the Sputnik tests?
On Tue, Aug 9, 2011 at 10:14 AM, <[email protected]> wrote: > Reviewers: Rico, > > Description: > Fixed extremely important, mission-critical presubmit warnings... > > Please review this at http://codereview.chromium.org/7600019/ > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/lithium-codegen-arm.cc > > > Index: src/arm/lithium-codegen-arm.cc > =================================================================== > --- src/arm/lithium-codegen-arm.cc (revision 8859) > +++ src/arm/lithium-codegen-arm.cc (working copy) > @@ -1679,8 +1679,8 @@ > __ b(ne, ¬_heap_number); > __ vldr(dbl_scratch, FieldMemOperand(reg, > HeapNumber::kValueOffset)); > __ VFPCompareAndSetFlags(dbl_scratch, 0.0); > - __ b(vs, false_label); // NaN -> false. > - __ b(eq, false_label); // +0, -0 -> false. > + __ b(vs, false_label); // NaN -> false. > + __ b(eq, false_label); // +0, -0 -> false. > __ b(true_label); > __ bind(¬_heap_number); > } else if (expected.Contains(ToBooleanStub::INTERNAL_OBJECT)) { > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
