LGTM.
http://codereview.chromium.org/7604028/diff/6002/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7604028/diff/6002/src/arm/lithium-codegen-arm.cc#newcode3017 src/arm/lithium-codegen-arm.cc:3017: Register scratch2 = scratch0(); It doesn't really make sense to have scratch2 when there is no scratch1 (and have it be an alias for scratch0!). Maybe call it scratch? http://codereview.chromium.org/7604028/diff/6002/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/7604028/diff/6002/src/ia32/lithium-codegen-ia32.cc#newcode2770 src/ia32/lithium-codegen-ia32.cc:2770: __ movmskpd(output_reg, input_reg); Gesundheit. http://codereview.chromium.org/7604028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
