Revision: 8895
Author:   [email protected]
Date:     Thu Aug 11 05:34:10 2011
Log:      Merge revision 8894 from bleeding_edge

Revert some .gyp refactoring to fix ARM cross-compilation

Review URL: http://codereview.chromium.org/7622007
http://code.google.com/p/v8/source/detail?r=8895

Modified:
 /trunk/build/v8-features.gypi
 /trunk/src/version.cc
 /trunk/tools/gyp/v8.gyp

=======================================
--- /trunk/build/v8-features.gypi       Wed Aug 10 07:15:35 2011
+++ /trunk/build/v8-features.gypi       Thu Aug 11 05:34:10 2011
@@ -96,12 +96,6 @@
                 'defines': [
                   'USE_EABI_HARDFLOAT=0',
                 ],
-              }],
-              # The ARM assembler assumes the host is 32 bits,
-              # so force building 32-bit host tools.
-              [ 'host_arch=="x64" and _toolset=="host "', {
-                'cflags': ['-m32'],
-                'ldflags': ['-m32'],
               }],
             ],
           }],
=======================================
--- /trunk/src/version.cc       Wed Aug 10 07:15:35 2011
+++ /trunk/src/version.cc       Thu Aug 11 05:34:10 2011
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     5
 #define BUILD_NUMBER      4
-#define PATCH_LEVEL       1
+#define PATCH_LEVEL       2
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0
=======================================
--- /trunk/tools/gyp/v8.gyp     Wed Aug 10 07:15:35 2011
+++ /trunk/tools/gyp/v8.gyp     Thu Aug 11 05:34:10 2011
@@ -111,12 +111,6 @@
                     'defines': [
                       'USE_EABI_HARDFLOAT=0',
                     ],
-                  }],
-                  # The ARM assembler assumes the host is 32 bits,
-                  # so force building 32-bit host tools.
-                  [ 'host_arch=="x64" and _toolset=="host"', {
-                    'cflags': ['-m32'],
-                    'ldflags': ['-m32'],
                   }],
                 ],
               }],
@@ -323,6 +317,13 @@
               'toolsets': ['target'],
               'dependencies': ['mksnapshot', 'js2c'],
             }],
+            # The ARM assembler assumes the host is 32 bits,
+            # so force building 32-bit host tools.
+            ['v8_target_arch=="arm" and host_arch=="x64" and \
+              _toolset=="host"', {
+              'cflags': ['-m32'],
+              'ldflags': ['-m32'],
+            }],
             ['component=="shared_library"', {
               'conditions': [
                 ['OS=="win"', {
@@ -426,6 +427,13 @@
             '../../src/snapshot-empty.cc',
           ],
           'conditions': [
+            # The ARM assembler assumes the host is 32 bits,
+            # so force building 32-bit host tools.
+            ['v8_target_arch=="arm" and host_arch=="x64" and \
+              _toolset=="host"', {
+              'cflags': ['-m32'],
+              'ldflags': ['-m32'],
+            }],
             ['want_separate_host_toolset==1', {
               'toolsets': ['host', 'target'],
               'dependencies': ['js2c#host'],
@@ -737,6 +745,14 @@
                 '../../src/arm/simulator-arm.cc',
                 '../../src/arm/stub-cache-arm.cc',
               ],
+              'conditions': [
+                # The ARM assembler assumes the host is 32 bits,
+                # so force building 32-bit host tools.
+                ['host_arch=="x64" and _toolset=="host"', {
+                  'cflags': ['-m32'],
+                  'ldflags': ['-m32'],
+                }],
+              ],
             }],
['v8_target_arch=="ia32" or v8_target_arch=="mac" or OS=="mac"', {
               'sources': [
@@ -975,6 +991,13 @@
             }, {
               'toolsets': ['target'],
             }],
+            # The ARM assembler assumes the host is 32 bits,
+            # so force building 32-bit host tools.
+            ['v8_target_arch=="arm" and host_arch=="x64" and \
+              _toolset=="host"', {
+              'cflags': ['-m32'],
+              'ldflags': ['-m32'],
+            }],
             ['v8_compress_startup_data=="bz2"', {
               'libraries': [
                 '-lbz2',
@@ -1040,7 +1063,13 @@
             }, {
               'toolsets': ['target'],
             }],
-
+            # The ARM assembler assumes the host is 32 bits,
+            # so force building 32-bit host tools.
+            ['v8_target_arch=="arm" and host_arch=="x64" and \
+              _toolset=="host"', {
+              'cflags': ['-m32'],
+              'ldflags': ['-m32'],
+            }],
           ],
           'link_settings': {
             'libraries': [

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to