[v8-dev] v8: Pick the namespace alias 'i' from v8.h. (issue7640012)

Thu, 11 Aug 2011 18:14:15 -0700 

Reviewers: Mikhail Naganov (Chromium),

Description:
v8: Pick the namespace alias 'i' from v8.h.

These files already include v8.h so they don't need to define the
namespace alias again.

Signed-off-by: Thiago Farina <[email protected]>


Please review this at http://codereview.chromium.org/7640012/

SVN Base: git://github.com/v8/v8.git@master

Affected files:
  M src/d8.h
  M src/mksnapshot.cc
  M src/preparser.cc
  M test/cctest/test-accessors.cc
  M test/cctest/test-circular-queue.cc
  M test/cctest/test-cpu-profiler.cc
  M test/cctest/test-heap-profiler.cc
  M test/cctest/test-log-stack-tracer.cc
  M test/cctest/test-log.cc
  M test/cctest/test-parsing.cc
  M test/cctest/test-profile-generator.cc
  M test/cctest/test-unbound-queue.cc


Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index 40cc83b055ea9a7e1e11d8e304d06b20ccb08735..28321f56dae720dd2e02d56881132966f53921c7 100644 
--- a/src/d8.h
+++ b/src/d8.h
@@ -39,10 +39,6 @@

 namespace v8 {

-#ifndef V8_SHARED
-namespace i = v8::internal;
-#endif  // V8_SHARED
-

 #ifndef V8_SHARED
 // A single counter in a counter collection.
Index: src/mksnapshot.cc
diff --git a/src/mksnapshot.cc b/src/mksnapshot.cc
index c5ce12f0ecaaa6eb43b0bbe9402bd3fba0ea80f9..4f5fe96a9027e822f4b359555f436842a0774d81 100644 
--- a/src/mksnapshot.cc
+++ b/src/mksnapshot.cc
@@ -40,8 +40,6 @@
 #include "serialize.h"
 #include "list.h"

-// use explicit namespace to avoid clashing with types in namespace v8
-namespace i = v8::internal;
 using namespace v8;

 static const unsigned int kMaxCounters = 256;
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index c741b4655a0556d4450c94608a69ad6316d4e9fa..463df83dbbbfeda503c8a1fee115063dc8522b84 100644 
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -56,8 +56,6 @@ namespace preparser {
 // That means that contextual checks (like a label being declared where
 // it is used) are generally omitted.

-namespace i = ::v8::internal;
-
 void PreParser::ReportUnexpectedToken(i::Token::Value token) {
   // We don't report stack overflows here, to avoid increasing the
   // stack depth even further.  Instead we report it after parsing is
Index: test/cctest/test-accessors.cc
diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc
index 028f82f3dc61560f31694c9535b2392dc4179b15..d95536d2d5dfc0f7ae0686d4d2f186da0860f3a1 100644 
--- a/test/cctest/test-accessors.cc
+++ b/test/cctest/test-accessors.cc
@@ -44,8 +44,6 @@ using ::v8::Function;
 using ::v8::AccessorInfo;
 using ::v8::Extension;

-namespace i = ::v8::internal;
-
 static v8::Handle<Value> handle_property(Local<String> name,
                                          const AccessorInfo&) {
   ApiTestFuzzer::Fuzz();
Index: test/cctest/test-circular-queue.cc
diff --git a/test/cctest/test-circular-queue.cc b/test/cctest/test-circular-queue.cc index c4e5c4c24d14cd53255500437461df2786158356..2861b1f76e05759aed52aae0c0ea53a54cc2232d 100644 
--- a/test/cctest/test-circular-queue.cc
+++ b/test/cctest/test-circular-queue.cc
@@ -6,8 +6,6 @@
 #include "circular-queue-inl.h"
 #include "cctest.h"

-namespace i = v8::internal;
-
 using i::SamplingCircularQueue;


Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc index 9ff2a171a3d9baafe18d59b8514d7b44fbf37267..81c487da8a3db1feedafd0aa7da0a3debdbd95fc 100644 
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -7,8 +7,6 @@
 #include "cctest.h"
 #include "../include/v8-profiler.h"

-namespace i = v8::internal;
-
 using i::CodeEntry;
 using i::CpuProfile;
 using i::CpuProfiler;
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc index 8675a0146ce172d06e1c067c5c0661722c517d97..169e6dcbdb601209c2c4ec562c00ad9cc7c74005 100644 
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -10,8 +10,6 @@
 #include "utils-inl.h"
 #include "../include/v8-profiler.h"

-namespace i = v8::internal;
-
 namespace {

 class NamedEntriesDetector {
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc index 2bcb3fe0b6f895d28a573a6b746f2bb3b60660e5..f536e6b193e196cb95967f6d5c6ea15d24005f13 100644 
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -54,8 +54,6 @@ using v8::internal::JSFunction;
 using v8::internal::StackTracer;
 using v8::internal::TickSample;

-namespace i = v8::internal;
-

 static v8::Persistent<v8::Context> env;

Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index 262e7bb505264909b277ecc406d2f9cf30028ac4..dfbc733e0df0623c40f3904fc04c50e596e7fe2d 100644 
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -23,8 +23,6 @@ using v8::internal::EmbeddedVector;
 using v8::internal::Logger;
 using v8::internal::StrLength;

-namespace i = v8::internal;
-
 namespace {

 class ScopedLoggerInitializer {
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index fe738768d6d241c6b8ab7d3d657989ba92582a68..654c6cf73286e533a04bb0b281c50d658362f52b 100755 
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -40,8 +40,6 @@
 #include "preparser.h"
 #include "cctest.h"

-namespace i = ::v8::internal;
-
 TEST(ScanKeywords) {
   struct KeywordToken {
     const char* keyword;
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc index 6d30443178902295709d05b443c13f8952daaa52..250ebd4a5f275ccb38ffd497b7906721b524e33c 100644 
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -7,8 +7,6 @@
 #include "cctest.h"
 #include "../include/v8-profiler.h"

-namespace i = v8::internal;
-
 using i::CodeEntry;
 using i::CodeMap;
 using i::CpuProfile;
Index: test/cctest/test-unbound-queue.cc
diff --git a/test/cctest/test-unbound-queue.cc b/test/cctest/test-unbound-queue.cc index df5509ef87fe38be70c4042c457418f0959ec0e4..3dc87ae246211c6c0a269f2993cb11247044b2b5 100644 
--- a/test/cctest/test-unbound-queue.cc
+++ b/test/cctest/test-unbound-queue.cc
@@ -6,8 +6,6 @@
 #include "unbound-queue-inl.h"
 #include "cctest.h"

-namespace i = v8::internal;
-
 using i::UnboundQueue;




--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to