http://codereview.chromium.org/7621014/diff/5001/src/heap.cc File src/heap.cc (right):
http://codereview.chromium.org/7621014/diff/5001/src/heap.cc#newcode738 src/heap.cc:738: old_gen_limit_factor_ = 1; On 2011/08/12 09:11:51, Vyacheslav Egorov wrote:
I think you wanted 2 here.
Good point. http://codereview.chromium.org/7621014/diff/5001/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7621014/diff/5001/src/heap.h#newcode1233 src/heap.h:1233: limit += new_space_.Capacity(); On 2011/08/12 09:11:51, Vyacheslav Egorov wrote:
new_space_.Capacity can change while lazy sweeping is in progress.
So Lower... will fluctuate. Is it intentional?
No, but I don't think it matters. http://codereview.chromium.org/7621014/diff/5001/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7621014/diff/5001/src/spaces.cc#newcode1933 src/spaces.cc:1933: if (FLAG_trace_gc && first_unswept_page_ != NULL) { On 2011/08/12 09:11:51, Vyacheslav Egorov wrote:
_verbose
Actually this happens rarely and if it happens it might be an issue to so I will leave it in. http://codereview.chromium.org/7621014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
