LGTM if the -0 handling is really needed (a short comment why would be good then).
General remark: The spec states "The value of Math.ceil(x) is the same as the
value of -Math.floor(-x).", so can we do something similar there? http://codereview.chromium.org/7628017/diff/4002/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (left): http://codereview.chromium.org/7628017/diff/4002/src/ia32/full-codegen-ia32.cc#oldcode3833 src/ia32/full-codegen-ia32.cc:3833: // TODO(svenpanne): Allowing format strings in Comment would be nice here... Not really related to the current patch, but I guess we can remove this TODO, anyway... ;-) http://codereview.chromium.org/7628017/diff/4002/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/7628017/diff/4002/src/ia32/lithium-codegen-ia32.cc#newcode2720 src/ia32/lithium-codegen-ia32.cc:2720: // Deoptimize on negative zero. Why do we have to deoptimize on -0 when using roundsd? http://codereview.chromium.org/7628017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
