Revision: 8919
Author: [email protected]
Date: Fri Aug 12 02:49:55 2011
Log: Pick the namespace alias 'i' from v8.h.
These files already include v8.h so they don't need to define the
namespace alias again.
Signed-off-by: Thiago Farina <[email protected]>
Review URL: http://codereview.chromium.org/7640012
http://code.google.com/p/v8/source/detail?r=8919
Modified:
/branches/bleeding_edge/src/d8.h
/branches/bleeding_edge/src/mksnapshot.cc
/branches/bleeding_edge/src/preparser.cc
/branches/bleeding_edge/test/cctest/test-accessors.cc
/branches/bleeding_edge/test/cctest/test-circular-queue.cc
/branches/bleeding_edge/test/cctest/test-cpu-profiler.cc
/branches/bleeding_edge/test/cctest/test-heap-profiler.cc
/branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc
/branches/bleeding_edge/test/cctest/test-log.cc
/branches/bleeding_edge/test/cctest/test-parsing.cc
/branches/bleeding_edge/test/cctest/test-profile-generator.cc
/branches/bleeding_edge/test/cctest/test-unbound-queue.cc
=======================================
--- /branches/bleeding_edge/src/d8.h Mon Aug 8 02:34:18 2011
+++ /branches/bleeding_edge/src/d8.h Fri Aug 12 02:49:55 2011
@@ -39,10 +39,6 @@
namespace v8 {
-#ifndef V8_SHARED
-namespace i = v8::internal;
-#endif // V8_SHARED
-
#ifndef V8_SHARED
// A single counter in a counter collection.
=======================================
--- /branches/bleeding_edge/src/mksnapshot.cc Wed Jul 13 02:09:04 2011
+++ /branches/bleeding_edge/src/mksnapshot.cc Fri Aug 12 02:49:55 2011
@@ -40,8 +40,6 @@
#include "serialize.h"
#include "list.h"
-// use explicit namespace to avoid clashing with types in namespace v8
-namespace i = v8::internal;
using namespace v8;
static const unsigned int kMaxCounters = 256;
=======================================
--- /branches/bleeding_edge/src/preparser.cc Wed Jul 6 02:15:10 2011
+++ /branches/bleeding_edge/src/preparser.cc Fri Aug 12 02:49:55 2011
@@ -56,8 +56,6 @@
// That means that contextual checks (like a label being declared where
// it is used) are generally omitted.
-namespace i = ::v8::internal;
-
void PreParser::ReportUnexpectedToken(i::Token::Value token) {
// We don't report stack overflows here, to avoid increasing the
// stack depth even further. Instead we report it after parsing is
=======================================
--- /branches/bleeding_edge/test/cctest/test-accessors.cc Tue Apr 5
02:01:47 2011
+++ /branches/bleeding_edge/test/cctest/test-accessors.cc Fri Aug 12
02:49:55 2011
@@ -44,8 +44,6 @@
using ::v8::AccessorInfo;
using ::v8::Extension;
-namespace i = ::v8::internal;
-
static v8::Handle<Value> handle_property(Local<String> name,
const AccessorInfo&) {
ApiTestFuzzer::Fuzz();
=======================================
--- /branches/bleeding_edge/test/cctest/test-circular-queue.cc Fri Jun 10
02:54:04 2011
+++ /branches/bleeding_edge/test/cctest/test-circular-queue.cc Fri Aug 12
02:49:55 2011
@@ -6,8 +6,6 @@
#include "circular-queue-inl.h"
#include "cctest.h"
-namespace i = v8::internal;
-
using i::SamplingCircularQueue;
=======================================
--- /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Wed Jul 13
02:09:04 2011
+++ /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Fri Aug 12
02:49:55 2011
@@ -7,8 +7,6 @@
#include "cctest.h"
#include "../include/v8-profiler.h"
-namespace i = v8::internal;
-
using i::CodeEntry;
using i::CpuProfile;
using i::CpuProfiler;
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap-profiler.cc Wed Jul 13
02:09:04 2011
+++ /branches/bleeding_edge/test/cctest/test-heap-profiler.cc Fri Aug 12
02:49:55 2011
@@ -10,8 +10,6 @@
#include "utils-inl.h"
#include "../include/v8-profiler.h"
-namespace i = v8::internal;
-
namespace {
class NamedEntriesDetector {
=======================================
--- /branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc Wed Jul 13
03:08:52 2011
+++ /branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc Fri Aug 12
02:49:55 2011
@@ -54,8 +54,6 @@
using v8::internal::StackTracer;
using v8::internal::TickSample;
-namespace i = v8::internal;
-
static v8::Persistent<v8::Context> env;
=======================================
--- /branches/bleeding_edge/test/cctest/test-log.cc Thu Jul 14 04:38:18 2011
+++ /branches/bleeding_edge/test/cctest/test-log.cc Fri Aug 12 02:49:55 2011
@@ -23,8 +23,6 @@
using v8::internal::Logger;
using v8::internal::StrLength;
-namespace i = v8::internal;
-
namespace {
class ScopedLoggerInitializer {
=======================================
--- /branches/bleeding_edge/test/cctest/test-parsing.cc Tue Aug 9 06:32:53
2011
+++ /branches/bleeding_edge/test/cctest/test-parsing.cc Fri Aug 12 02:49:55
2011
@@ -40,8 +40,6 @@
#include "preparser.h"
#include "cctest.h"
-namespace i = ::v8::internal;
-
TEST(ScanKeywords) {
struct KeywordToken {
const char* keyword;
=======================================
--- /branches/bleeding_edge/test/cctest/test-profile-generator.cc Wed Jul
13 03:08:52 2011
+++ /branches/bleeding_edge/test/cctest/test-profile-generator.cc Fri Aug
12 02:49:55 2011
@@ -7,8 +7,6 @@
#include "cctest.h"
#include "../include/v8-profiler.h"
-namespace i = v8::internal;
-
using i::CodeEntry;
using i::CodeMap;
using i::CpuProfile;
=======================================
--- /branches/bleeding_edge/test/cctest/test-unbound-queue.cc Tue Dec 7
03:01:02 2010
+++ /branches/bleeding_edge/test/cctest/test-unbound-queue.cc Fri Aug 12
02:49:55 2011
@@ -6,8 +6,6 @@
#include "unbound-queue-inl.h"
#include "cctest.h"
-namespace i = v8::internal;
-
using i::UnboundQueue;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
