Reviewers: Jungshik Shin,

Message:
This API will probably disappear soon, but lets fix it.

Description:
Return error not null for date time format.

BUG=1602
TEST=new (new v8Locale().createDateTimeFormat()).getWeekdays should return Error
not a Null.

Please review this at http://codereview.chromium.org/7647027/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/extensions/experimental/datetime-format.cc


Index: src/extensions/experimental/datetime-format.cc
===================================================================
--- src/extensions/experimental/datetime-format.cc      (revision 8679)
+++ src/extensions/experimental/datetime-format.cc      (working copy)
@@ -135,7 +135,7 @@
v8::Handle<v8::Value> DateTimeFormat::GetWeekdays(const v8::Arguments& args) {
   icu::SimpleDateFormat* date_format = UnpackDateTimeFormat(args.Holder());
   if (!date_format) {
-    ThrowUnexpectedObjectError();
+    return ThrowUnexpectedObjectError();
   }

const icu::DateFormatSymbols* symbols = date_format->getDateFormatSymbols();


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to