http://codereview.chromium.org/7616009/diff/11001/test/mjsunit/harmony/block-scoping.js File test/mjsunit/harmony/block-scoping.js (right):
http://codereview.chromium.org/7616009/diff/11001/test/mjsunit/harmony/block-scoping.js#newcode118 test/mjsunit/harmony/block-scoping.js:118: // Variable shadowing. What about shadowing between "var" and "let"? http://codereview.chromium.org/7616009/diff/11001/test/mjsunit/harmony/block-scoping.js#newcode123 test/mjsunit/harmony/block-scoping.js:123: let b = 2; You might want to put in more assertions (here and below) checking that lookup also gives the right binding in all shadowing scenarios. http://codereview.chromium.org/7616009/diff/11001/test/mjsunit/harmony/block-scoping.js#newcode169 test/mjsunit/harmony/block-scoping.js:169: function f8() { You never invoke this. ;-) http://codereview.chromium.org/7616009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
